feat: add support for secrets in http checks #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ugal
changed the base branch from
main
to
feature/pr1-core-secret-infrastructure-and-interpolation
d0ugal
changed the base branch from
feature/pr1-core-secret-infrastructure-and-interpolation
to
main
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
from
31370e9 to
b4fdd61
Compare
d0ugal
changed the title
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
2 times, most recently
from
06488b9 to
b050ec1
Compare
d0ugal
changed the title
d0ugal
changed the title
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
5 times, most recently
from
2f66c0b to
822cbe3
Compare
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
4 times, most recently
from
6ad9c7a to
afc0633
Compare
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
2 times, most recently
from
d87f053 to
44e7a89
Compare
d0ugal
commented
Sep 9, 2025
There was a problem hiding this comment.
@mem this is the file that I mentioned in our call
mem
reviewed
Sep 13, 2025
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
from
44e7a89 to
51d5830
Compare
mem
previously approved these changes
Oct 15, 2025
d0ugal
force-pushed
the
feature/pr2-http-prober-secret-integration
branch
from
51d5830 to
a9cafb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1468 and adds support to http checks.
String interpolation is supported in the basic auth password field, bearer token and TLS fields.
If #1468 hasn't merged it is best to look at the individual commits as its included.